Skip to content

Conversation

@didinele
Copy link
Member

@didinele didinele commented Nov 17, 2025

should I have ignored api-extractor?

Closes #11272

@vercel
Copy link

vercel bot commented Nov 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Nov 24, 2025 8:37am
discord-js-guide Ignored Ignored Preview Nov 24, 2025 8:37am

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.72%. Comparing base (e8217e3) to head (1717188).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11279      +/-   ##
==========================================
- Coverage   44.76%   44.72%   -0.05%     
==========================================
  Files         316      316              
  Lines       18164    18146      -18     
  Branches     1811     1813       +2     
==========================================
- Hits         8132     8115      -17     
+ Misses      10020    10019       -1     
  Partials       12       12              
Flag Coverage Δ
brokers 28.00% <ø> (-0.29%) ⬇️
builders 80.60% <ø> (ø)
collection 100.00% <ø> (ø)
core 0.90% <ø> (ø)
formatters 99.67% <ø> (ø)
proxy 65.47% <ø> (-0.41%) ⬇️
rest 87.55% <ø> (-0.02%) ⬇️
structures 85.19% <ø> (ø)
util 43.42% <ø> (ø)
utilities 6.07% <ø> (+0.02%) ⬆️
voice 61.31% <100.00%> (-0.17%) ⬇️
ws 36.20% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Qjuh Qjuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

including api-extractor in this change is correct

Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the eslint.config.js files in the templates for create-discord-bot too? Otherwise the linter will (probably) fail when people create a new project using it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Remove usage of n/prefer-global rules across the monorepo

4 participants